|
| From: | Hans de Goede |
| Subject: | Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3) |
| Date: | Sun, 24 Jul 2011 20:15:19 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Lightning/1.0b2 Thunderbird/3.1.11 |
Hi, On 07/22/2011 02:40 PM, Gerd Hoffmann wrote:
ACK. Another option would be to not call the state callback for the vdagent subtype from spice-server, because like you say it ignores the continued communication between the agent and the server. Then you could remove the subtype check.We can even #ifdef the check using SPICE_SERVER_VERSION once the spice-server change is committed, and in a year or so we can raise the minimum required spice-server version and remove some #ifdef clutter.
Yeah that is more or less what I proposed in the last mail in the spice-devel mailinglist thread, I'm glad you agree. I'll prepare a patch to remove the state calls from the spice-server vdagent handling. Regards, Hans
| [Prev in Thread] | Current Thread | [Next in Thread] |