[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medi
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medium load |
|
Date: |
Fri, 22 Jul 2011 17:33:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 20.07.2011 18:23, schrieb Markus Armbruster:
>> Commit aea2a33c made bdrv_eject() obey the locked flag. Correct for
>> medium eject (eject_flag set), incorrect for medium load (eject_flag
>> clear). See MMC-5 Table 341 "Actions for Lock/Unlock/Eject".
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> SCSI doesn't really matter here, this is about host state. The comment
> for bdrv_set_locked only talks about eject, so it's probably right anyway.
For what it's worth, PATCH 28/55 moves this check to the device models,
where MMC-5 clearly applies.
- Re: [Qemu-devel] [PATCH 01/55] blockdev: Make eject fail for non-removable drives even with -f, (continued)
- [Qemu-devel] [PATCH 06/55] block/raw-win32: Drop disabled code for removable host devices, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medium load, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 21/55] block: Revert entanglement of bdrv_is_inserted() with tray status, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 27/55] scsi-disk: Switch from BlockDriverState's locked to own tray_locked, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 04/55] block: Generalize change_cb() to BlockDevOps, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 13/55] ide: Use a table to declare which drive kinds accept each command, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM, Markus Armbruster, 2011/07/20