Re: [Qemu-devel] [PATCH 08/23] PPC: Bump MPIC up to 32 supported CPUs

[Alexander Graf]

On 22.07.2011, at 16:10, Elie Richa wrote:

> 
> On 07/21/2011 03:27 AM, Alexander Graf wrote:
>> @@ -1288,7 +1288,7 @@ static void mpic_reset (void *opaque)
>> 
>>      mpp->glbc = 0x80000000;
>>      /* Initialise controller registers */
>> -    mpp->frep = 0x004f0002;
>> +    mpp->frep = 0x004f0002 | ((MAX_CPU - 1)<<  8);
> 
> Should we really report the maximum supported number of CPUs or the actual 
> number?
> Several processor manuals state that it is the number of physically present 
> CPUs that is reported (-1 of course).
> In that case, the following would do?
>       mpp->frep = 0x004f0002 | ((mpp->nb_cpus - 1)<<  8);

Good idea. Will change :)


Alex