Re: [Qemu-devel] [PATCH] exec.h cleanup

[Blue Swirl]

On Sun, Jul 17, 2011 at 6:31 PM, Peter Maydell <address@hidden> wrote:
> On 17 July 2011 13:31, Blue Swirl <address@hidden> wrote:
>> diff --git a/target-arm/iwmmxt_helper.c b/target-arm/iwmmxt_helper.c
>> index ebe6eb9..fbd3547 100644
>> --- a/target-arm/iwmmxt_helper.c
>> +++ b/target-arm/iwmmxt_helper.c
>> @@ -23,7 +23,7 @@
>>  #include <stdio.h>
>>
>>  #include "cpu.h"
>> -#include "exec.h"
>> +#include "dyngen-exec.h"
>>  #include "helper.h"
>>
>>  /* iwMMXt macros extracted from GNU gdb.  */
>
> I think this change and the neon one are superfluous once the changes 
> currently
> in my target-arm pull-request [http://patchwork.ozlabs.org/patch/101524/ from
> 2011-06-22] get applied; those revert the changes which gave iwmmxt_helper.c
> and neon_helper.c access to the implicit global env, so they don't include
> exec.h any more.

I pulled the patches, thanks.