[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest |
Date: |
Wed, 20 Jul 2011 15:49:40 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 19, 2011 at 11:20:22PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote:
> >
> > This breaks the build:
> >
> > make[1]: Nothing to be done for `all'.
> > CC ppc64-softmmu/spapr_vscsi.o
> > /home/anthony/git/qemu/hw/spapr_vscsi.c: In function
> > ‘vscsi_command_complete’:
> > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: error: ‘s’ undeclared
> > (first use in this function)
> > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: note: each undeclared
> > identifier is reported only once for each function it appears in
> >
> > This file is only built when libfdt is installed which is probably
> > why
> > you didn't catch it.
> >
> > Ben/David, is there a way we can still build most of this stuff
> > without
> > libfdt? libfdt is still not commonly packaged by some distros.
>
> That would be hard ... the DT stuff is pretty deeply involved. Might be
> easier to try to fix the distro :-)
Actually, I think what we should do is embed libfdt into qemu. It's
small, it will remove a bunch of irritating config dependencies, and
it's designed to embeddable in this way.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [PATCH 12/21] VMDK: probe for monolithicFlat images, (continued)
- [Qemu-devel] [PATCH 12/21] VMDK: probe for monolithicFlat images, Kevin Wolf, 2011/07/19
- [Qemu-devel] [PATCH 10/21] VMDK: introduce VmdkExtent, Kevin Wolf, 2011/07/19
- [Qemu-devel] [PATCH 11/21] VMDK: bugfix, align offset to cluster in get_whole_cluster, Kevin Wolf, 2011/07/19
- [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest, Kevin Wolf, 2011/07/19
- Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest, Benjamin Herrenschmidt, 2011/07/19
- Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest,
David Gibson <=
[Qemu-devel] [PATCH 13/21] VMDK: separate vmdk_open by format version, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 02/21] qemu-io: Fix formatting, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 15/21] VMDK: flush multiple extents, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 07/21] scsi-disk: Mask out serial number EVPD, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 16/21] VMDK: move 'static' cid_update flag to bs field, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 17/21] VMDK: change get_cluster_offset return type, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 14/21] VMDK: add field BDRVVmdkState.desc_offset, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 18/21] VMDK: open/read/write for monolithicFlat image, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 21/21] block: add bdrv_get_allocated_file_size() operation, Kevin Wolf, 2011/07/19
[Qemu-devel] [PATCH 19/21] VMDK: create different subformats, Kevin Wolf, 2011/07/19