Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command

[Paolo Bonzini]

On 07/14/2011 10:45 AM, Michal Novotny wrote:
> >  Please inline all these instead of adding new functions.
>
> Do you mean to implement as macros? I'm trying since yesterday and it's
> not that simple because the variable has to be accessible from 3 files -
> arch_init.c, savevm.c and migration.c. So I need to figure out what file
> to put the variables to to make it working fine.

I would like to avoid using them in multiple files.

The simplest change is to remove migration.c from the list.  The 
"waiting for input" handling can be moved to qemu_savevm_state_begin and 
qemu_savevm_state_iterate.  The monitor code can be moved to savevm.c as 
well.

And also, it makes no sense that arch_init.c includes savevm-related 
code.  It was done simply to avoid compiling savevm more than once (to 
put it in Makefile.objs instead of Makefile.target).  If you move that 
code back to savevm.c, the list of files goes down to one.

Paolo