[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm |
Date: |
Wed, 13 Jul 2011 14:29:16 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote:
> On 07/13/11 11:29, Alon Levy wrote:
> >On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote:
> >>On 07/12/11 15:55, Alon Levy wrote:
> >>>Later the save will happen asynchronously on surface_updated callback.
> >>
> >>Hmm. I can see why you are doing that. It makes the file being
> >>written *after* the monitor command finishes though, which I think
> >>we should avoid.
> >
> >I think the simplest thing would be to add a specific cond for this -
> >ppm_save_filename_cond. ok?
>
> Not sure. Luiz, do we have async monitor commands meanwhile?
>
> Background: screendump for qxl vga can take a while as the
> spice-server might have to render everything first ...
I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's
becoming pretty
ugly. Also I guess what Daniel described is possible, but it changes the usage
of screendump
even more. Is turning do_screen_dump to async viable? I think I'll work on it.
>
> cheers,
> Gerd
>
- [Qemu-devel] [PATCHv3] qxl: remove qxl_destroy_primary(), (continued)
- [Qemu-devel] [PATCHv3] qxl: remove qxl_destroy_primary(), Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: fix surface tracking & locking, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: bump pci rev, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: make qxl_guest_bug take variable arguments, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: error handling fixes and cleanups., Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/12
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Daniel P. Berrange, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm,
Alon Levy <=
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Daniel P. Berrange, 2011/07/13