Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

[tsnsaito]

Hi,

At Wed, 13 Jul 2011 10:57:19 +0200,
Artyom Tarasenko wrote:

> On Wed, Jul 13, 2011 at 5:30 AM, Tsuneo Saito <address@hidden> wrote:
> > Hi,
> >
> > This patch series implements sparcv9 stfa/ldfa instructions with
> > non block-transfer ASIs that implementations seem to be left unfinished.
> > This patch also adds fp_disabled exception checks on stfa/ldfa
> > as they are FP instructions.
> 
> Nice series!
> May I ask what have you used as a test case to discover the problem?

I found the problem when I was trying to run the linux/sparc64 kernel.
It seemed that copy_to_user() did not work as expected.

> Please use the scripts/checkpatch.pl script to check coding style,
> there are some braces missing in 2/4 and 4/4 patches.
> The contents
> Acked-by: Artyom Tarasenko <address@hidden>

Thanks for the review!
I'll fix the coding style problems and post the fixed version. 

----
Tsuneo Saito <address@hidden>