[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas
From: |
Chris Wright |
Subject: |
Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas |
Date: |
Tue, 12 Jul 2011 12:18:31 -0700 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
* Chris Wright (address@hidden) wrote:
> * Stefan Hajnoczi (address@hidden) wrote:
> > @@ -199,6 +200,11 @@ static void change_process_uid(void)
> > fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid);
> > exit(1);
> > }
> > + if (initgroups(user_pwd->pw_name, user_pwd->pw_gid) < 0) {
> > + fprintf(stderr, "Failed to initgroups(\"%s\", %d)\n",
> > + user_pwd->pw_name, user_pwd->pw_gid);
> > + exit(1);
> > + }
>
> Does initgroups need access to /etc/group? How does this combine w/
> -chroot?
Tested this on Linux, and w/out /etc/group it simply fails to add any
supplementary groups (doesn't fail completely, just fails safely).
Appears similar from solaris manpages.
Given that...
Acked-by: Chris Wright <address@hidden>