[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] virtio-console: Prevent abort()s in case
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] virtio-console: Prevent abort()s in case of host chardev close |
Date: |
Tue, 12 Jul 2011 18:04:12 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Tue) 12 Jul 2011 [14:58:57], Amit Shah wrote:
> A host chardev could close just before the guest sends some data to be
> written. This will cause an -EPIPE error. This shouldn't be propagated
> to virtio-serial-bus.
>
> Ideally we should close the port once -EPIPE is received, but since the
> chardev interface doesn't return such meaningful values to its users,
> all we get is -1 for any kind of error. Just return 0 for now and wait
> for chardevs to return better error messages to act better on the return
> messages.
For v2, removed the check for -EAGAIN as qemu-char.c doesn't return
anything other than -1 for error conditions, as Markus and Juan noted.
Amit