[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v3 54/56] pci: remove pci_register_bar()
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [RFC v3 54/56] pci: remove pci_register_bar() |
Date: |
Sun, 10 Jul 2011 21:15:07 +0300 |
Superceded by pci_register_bar_region(). The implementations
are folded together.
Signed-off-by: Avi Kivity <address@hidden>
---
hw/pci.c | 42 +++++++++++++++++-------------------------
hw/pci.h | 3 ---
2 files changed, 17 insertions(+), 28 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 8c7a418..2543ced 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -881,13 +881,25 @@ static int pci_unregister_device(DeviceState *dev)
return 0;
}
-void pci_register_bar(PCIDevice *pci_dev, int region_num,
- pcibus_t size, uint8_t type,
- PCIMapIORegionFunc *map_func)
+static void pci_simple_bar_mapfunc_region(PCIDevice *pci_dev, int region_num,
+ pcibus_t addr, pcibus_t size,
+ int type)
+{
+ PCIIORegion *r = &pci_dev->io_regions[region_num];
+
+ memory_region_add_subregion_overlap(r->address_space,
+ addr,
+ r->memory,
+ 1);
+}
+
+void pci_register_bar_region(PCIDevice *pci_dev, int region_num,
+ uint8_t type, MemoryRegion *memory)
{
PCIIORegion *r;
uint32_t addr;
uint64_t wmask;
+ pcibus_t size = memory_region_size(memory);
assert(region_num >= 0);
assert(region_num < PCI_NUM_REGIONS);
@@ -902,7 +914,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
r->size = size;
r->filtered_size = size;
r->type = type;
- r->map_func = map_func;
+ r->map_func = pci_simple_bar_mapfunc_region;
r->ram_addr = IO_MEM_UNASSIGNED;
r->memory = NULL;
@@ -921,29 +933,9 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
pci_set_long(pci_dev->wmask + addr, wmask & 0xffffffff);
pci_set_long(pci_dev->cmask + addr, 0xffffffff);
}
-}
-
-static void pci_simple_bar_mapfunc_region(PCIDevice *pci_dev, int region_num,
- pcibus_t addr, pcibus_t size,
- int type)
-{
- PCIIORegion *r = &pci_dev->io_regions[region_num];
-
- memory_region_add_subregion_overlap(r->address_space,
- addr,
- r->memory,
- 1);
-}
-
-void pci_register_bar_region(PCIDevice *pci_dev, int region_num,
- uint8_t attr, MemoryRegion *memory)
-{
- pci_register_bar(pci_dev, region_num, memory_region_size(memory),
- attr,
- pci_simple_bar_mapfunc_region);
pci_dev->io_regions[region_num].memory = memory;
pci_dev->io_regions[region_num].address_space
- = attr & PCI_BASE_ADDRESS_SPACE_IO
+ = type & PCI_BASE_ADDRESS_SPACE_IO
? pci_dev->bus->address_space_io
: pci_dev->bus->address_space_mem;
}
diff --git a/hw/pci.h b/hw/pci.h
index c5174bd..3751b13 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -202,9 +202,6 @@ PCIDevice *pci_register_device(PCIBus *bus, const char
*name,
PCIConfigReadFunc *config_read,
PCIConfigWriteFunc *config_write);
-void pci_register_bar(PCIDevice *pci_dev, int region_num,
- pcibus_t size, uint8_t type,
- PCIMapIORegionFunc *map_func);
void pci_register_bar_region(PCIDevice *pci_dev, int region_num,
uint8_t attr, MemoryRegion *memory);
pcibus_t pci_get_bar_addr(PCIDevice *pci_dev, int region_num);
--
1.7.5.3
- Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API, (continued)
- [Qemu-devel] [RFC v3 55/56] pci: fold BAR mapping function into its caller, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 34/56] es1370: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 49/56] uhci: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 56/56] pci: rename pci_register_bar_region() to pci_register_bar(), Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 24/56] vga: simplify vga window mmio access functions, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 48/56] ehci: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 51/56] msix: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 54/56] pci: remove pci_register_bar(),
Avi Kivity <=
- [Qemu-devel] [RFC v3 42/56] ppc: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 45/56] i6300esb: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 32/56] e1000: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 46/56] isa-mmio: concert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 25/56] cirrus: simplify linear framebuffer access functions, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 41/56] lsi53c895a: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 35/56] ide: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 47/56] sun4u: convert to memory API, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 44/56] pcnet: convert to memory API, Avi Kivity, 2011/07/10