qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/4] omap_gpio: convert to qdev


From: Peter Maydell
Subject: [Qemu-devel] [PATCH v2 0/4] omap_gpio: convert to qdev
Date: Fri, 8 Jul 2011 17:56:17 +0100

These patches are changes from the meego omap3 tree which convert
the omap GPIO module device to use qdev.

Changes v1->v2:
 * renamed omap_l4_base() to omap_l4_region_base()
 * provide two qdev devices 'omap-gpio' and 'omap2-gpio' rather than
   trying to shoehorn two significantly different devices into one
   (and use hyphen rather than underscore in the device name)
 * wire up the omap clocks to the gpio modules as qdev properties
   (including adding a missing omap2 clock definition...)

We use qdev pointer properties for the omap clocks. This is not ideal.
My preference would be for qdev to support a generic means of defining
a 'port' with an arbitrary interface for connecting two devices. Then
we could reframe the omap clock API in terms of clock ports, and get
some type safety. For now passing an arbitrary pointer seems like the
best pragmatic interim solution. (It's not possible to pass in the
string which is the clock name, because the device does not have the
necessary information (ie the struct omap_mpu_state_s*) to do the
clockname to pointer translation.)

Juha Riihimäki (2):
  hw/omap_l4.c: Add helper function omap_l4_region_base
  hw/omap_gpio.c: Convert to qdev

Peter Maydell (2):
  hw/omap_gpio.c: Don't complain about some writes to r/o registers
  hw/omap_clk: Add the clock for the OMAP2430-specific fifth GPIO
    module

 hw/nseries.c   |   47 +++++-----
 hw/omap.h      |   22 +----
 hw/omap1.c     |   10 ++-
 hw/omap2.c     |   34 ++++++--
 hw/omap_clk.c  |    6 +-
 hw/omap_gpio.c |  263 ++++++++++++++++++++++++++++++++-----------------------
 hw/omap_l4.c   |    6 ++
 hw/palm.c      |   26 +++---
 8 files changed, 235 insertions(+), 179 deletions(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]