[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qxl: bump pci rev
|
From: |
Alon Levy |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qxl: bump pci rev |
|
Date: |
Fri, 8 Jul 2011 10:02:15 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jul 08, 2011 at 09:19:10AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >- DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, 2),
> >+ DEFINE_PROP_UINT32("revision", PCIQXLDevice, revision, 3),
>
> Can't be done unconditionally. With an older libspice we can't
> support the rev3 features.
ok. so this needs a runtime check for major_version.minor_version >= 3.1, no? a
compile
time won't work because someone can change the shared object, no? (maybe I
should just
check this scenario).
>
> cheers,
> Gerd
- [Qemu-devel] [PATCH v2] async + suspend reworked, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: use update_area_async in qxl-render, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: use QXL_REVISION_*, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: bump pci rev, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: make qxl_guest_bug take variable arguments, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: error handling fixes and cleanups., Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: add io_port_to_string, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: async I/O, Alon Levy, 2011/07/07