[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functi
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions |
Date: |
Wed, 6 Jul 2011 15:18:01 +0200 |
Am 06.07.2011 um 15:03 schrieb Hannes Reinecke <address@hidden>:
> On 07/06/2011 01:34 PM, Alexander Graf wrote:
>>
>>
>>
>>
>> On 06.07.2011, at 12:24, Paolo Bonzini<address@hidden> wrote:
>>
>>>> diff --git a/exec.c b/exec.c
>>>> index 5f2f87e..f281ba4 100644
>>>> --- a/exec.c
>>>> +++ b/exec.c
>>>> @@ -4127,7 +4127,8 @@ void cpu_physical_memory_unmap(void *buffer,
>>>> target_phys_addr_t len,
>>>> }
>>>>
>>>> /* warning: addr must be aligned */
>>>> -uint32_t ldl_phys(target_phys_addr_t addr)
>>>> +static inline uint32_t ldl_phys_internal(target_phys_addr_t addr,
>>>> + enum device_endian endian)
>>>
>>> You probably need the __always_inline__ attribute to really convince GCC to
>>> inline this.
>>
>> There's a define in osdep.h that converts inline into always_inline :)
>>
> Btw, while you're at it:
>
> uint32_t ldub_phys(target_phys_addr_t addr);
> uint32_t lduw_phys(target_phys_addr_t addr);
>
> Hmm? ldub is supposed to read an 'unsigned byte' (uint8_t),
> and lduw is supposed to read an 'unsigned word' (uint16_t).
>
> Why does it return an uint32_t?
Because it ends up being a 32-bit register for the return value / parameter
anyways :).
But this is a different thing. I'd prefer to focus on the endian problem for
now.
Alex
- [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, (continued)
- [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Alexander Graf, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Blue Swirl, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Alexander Graf, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Blue Swirl, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Alexander Graf, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Blue Swirl, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Alexander Graf, 2011/07/05
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Paolo Bonzini, 2011/07/06
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Alexander Graf, 2011/07/06
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Hannes Reinecke, 2011/07/06
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions,
Alexander Graf <=
- Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions, Paolo Bonzini, 2011/07/06
[Qemu-devel] [PATCH 6/9] pl080: use specific endian ld/st_phys, Alexander Graf, 2011/07/05
[Qemu-devel] [PATCH 9/9] spapr: use specific endian ld/st_phys, Alexander Graf, 2011/07/05
[Qemu-devel] [PATCH 5/9] msix: use specific endian ld/st_phys, Alexander Graf, 2011/07/05
[Qemu-devel] [PATCH 3/9] intel-hda: use specific endian ld/st_phys, Alexander Graf, 2011/07/05
Re: [Qemu-devel] [PATCH 0/9] Don't use ld./st._phys in hw/, Blue Swirl, 2011/07/05