qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny")
Date: Mon, 4 Jul 2011 22:02:36 +0100

On 4 July 2011 19:52, Stefan Weil <address@hidden> wrote:
> Some versions of png.h cannot be included after setjmp.h,
> even when PNG_SKIP_SETJMP_CHECK was defined.
>
> setjmp.h was included from qemu-common.h and is not needed there.
> Removing the include statement fixes compilation of ui/vnc-enc-tight.c
> with CONFIG_VNC_PNG defined.

This isn't the only unnecessary include of setjmp.h, incidentally.
The includes in target-alpha/cpu.h and target-ppc/cpu.h could
also be removed (cpu-defs.h includes setjmp.h). That would also
make those targets consistent with all the rest (which don't include
setjmp), so it seems worth the minor cleanup. I'll send a patch...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]