Re: [Qemu-devel] [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf()

[Hannes Reinecke]

On 07/01/2011 10:02 AM, Alexander Graf wrote:
> On 01.07.2011, at 09:42, Hannes Reinecke wrote:
>
> > Occasionally, the buffer needs to be placed at a offset within
> > the iovec when copying the buffer to the iovec.
>
> So this is a buffer into the iovec, right? Wouldn't it make sense
> to also modify iov_to_buf respectively then, so the API stays 
similar?

Ahem. That's exactly what the patch does. Except from the mixed-up 
subject.

iov_to_buff() has an offset parameter, iov_from_buf() has not.
For no obvious reasons.

> Also, it'd be nice to give the parameter a more obvious name, so potential
> users can easily recognize what it offsets.
>
Yes, that sounds reasonable.

What about 'iov_off' ?
(And possibly rename 'iovcnt' to 'iov_cnt' for consistency ?)

Cheers,

Hannes
--
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)