|
From: | Alexander Graf |
Subject: | Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw" |
Date: | Thu, 30 Jun 2011 13:47:47 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 |
On 06/24/2011 04:50 PM, address@hidden wrote:
From: Stefano Stabellini<address@hidden> Sometimes the toolstack uses "aio" without an additional format identifier, in such cases use "raw".
Shouldn't this rather be a patch to the toolstack then? We do automatic file format recognition as default. I find magical "aio equals raw" subtleties rather unintuitive.
Signed-off-by: Stefano Stabellini<address@hidden> --- hw/xen_disk.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 801da58..745127d 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -633,6 +633,8 @@ static int blk_init(struct XenDevice *xendev) blkdev->filename = blkdev->params; } } + if (!strcmp("aio", blkdev->fileproto)) + blkdev->fileproto = "raw";
Braces
if (blkdev->mode == NULL) { blkdev->mode = xenstore_read_be_str(&blkdev->xendev, "mode"); }
Alex
[Prev in Thread] | Current Thread | [Next in Thread] |