Re: [Qemu-devel] [PATCH] Add compat eventfd header

[Alexander Graf]

On 28.06.2011, at 17:35, Michael S. Tsirkin wrote:

> Support build on RHEL 5.X where we have syscall for eventfd but not
> userspace wrapper.
> 
> (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65
> in qemu-kvm.git).
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> compat/sys/eventfd.h |   13 +++++++++++++
> configure            |    4 +++
> 2 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 compat/sys/eventfd.h
> 
> diff --git a/compat/sys/eventfd.h b/compat/sys/eventfd.h
> new file mode 100644
> index 0000000..f55d96a
> --- /dev/null
> +++ b/compat/sys/eventfd.h
> @@ -0,0 +1,13 @@
> +#ifndef _COMPAT_SYS_EVENTFD
> +#define _COMPAT_SYS_EVENTFD
> +
> +#include <unistd.h>
> +#include <syscall.h>
> +
> +
> +static inline int eventfd (int count, int flags)

coding style seems wrong.

However, I'm not sure I like the idea of adding this code in qemu. Wouldn't the 
RHEL5 libc be a better place for such a wrapper?


Alex