qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.
Date: Tue, 28 Jun 2011 07:49:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/27/2011 08:07 PM, Peter Maydell wrote:
>  +    int ioport_base;
>  +    uint32_t ioport_reg[2];

I think ioport_reg[] needs to go in the VMStateDescription as well.
I don't know enough about the PCI subsystem to know whether that's
also true of ioport_base or whether the the map function is called
again on a vmload.

ioport_reg[1] is never written nor read, so this can be changed to a single uint32_t ioport_addr. Since it will be almost always 0 (either because it was never written, or because E1000_CTRL == 0), a subsection is useful to have.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]