Re: [Qemu-devel] [PATCH v3] showing a splash picture when start

[Wayne Xia]

> On 2011-06-27 08:53, Wayne Xia wrote:
> > Made an option to let qemu pass a picture to bios, let the bios show it as a
> > logo. By default it is off, enable it as following
>
> That's better. :)
>
> >      -boot splash_time=N,splash_filename=P
> > N have a max value of 0xffff, unit is ms. P is the a file name or a absolute
> > path.
> > Currently a trial version of sea-bios could be used to test it.
> >
> > Signed-off-by: Wayne Xia<address@hidden>
> > ---
>
> ...
    I think making the splash time configurable would be better, maybe
we could pass the configuration like following:
    -boot splash=P,<splash_time=N>
    only if splash=P was specified, the splash shows. In this
situation, if splash_time was not specified, then show it with a
predefined period, such as 2.5 seconds.
> > index c63741c..6f93b10 100644
> > --- a/qemu-config.c
> > +++ b/qemu-config.c
> > @@ -469,6 +469,32 @@ static QemuOptsList qemu_machine_opts = {
> >       },
> >   };
> >
> > +QemuOptsList qemu_bootsplash_opts = {
> > +    .name = "bootsplash",
> > +    .head = QTAILQ_HEAD_INITIALIZER(qemu_bootsplash_opts.head),
> > +    .desc = {
> > +        /* the three names below are not used now */
> > +        {
> > +            .name = "order",
> > +            .type = QEMU_OPT_STRING,
> > +        }, {
> > +            .name = "once",
> > +            .type = QEMU_OPT_STRING,
> > +        }, {
> > +            .name = "menu",
> > +            .type = QEMU_OPT_STRING,
> > +        /* following are really used */
> > +        }, {
> > +            .name = "splash_time",
> > +            .type = QEMU_OPT_STRING,
> > +        }, {
> > +            .name = "splash_filename",
> > +            .type = QEMU_OPT_STRING,
> > +        },
> > +        { /*End of list */ }
> > +    },
> > +};
> > +
>
> This is describing the "boot" option that also controls the splash.
> Naming should reflect this.
yeah, agree with you.
> Jan


--
Best Regards

Wayne Xia
mail:address@hidden
tel:86-010-82450803