|
From: | Andreas Färber |
Subject: | Re: [Qemu-devel] [PATCH v2] Optimize screendump |
Date: | Wed, 22 Jun 2011 23:22:06 +0200 |
Am 20.06.2011 um 15:11 schrieb Avi Kivity:
On 06/20/2011 03:33 PM, Jan Kiszka wrote:> --- a/hw/vga.c > +++ b/hw/vga.c> @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct DisplaySurface *ds)Unrelated to this patch, but why is this function located in vga.c andnot in console.c?It's located in omap_lcdc.c as well. But it needs to be fully generalized to be moved out (handle all PixelFormats).
For the record, there's a similar function in tcx.c as well, and I have one coming in ibm8514.c.
Andreas
[Prev in Thread] | Current Thread | [Next in Thread] |