Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

[Stefano Stabellini]

On Wed, 22 Jun 2011, address@hidden wrote:
> From: Anthony PERARD <address@hidden>
> 
> Signed-off-by: Anthony PERARD <address@hidden>
> ---
>  hw/piix_pci.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
>          .no_hotplug   = 1,
>          .init         = piix3_initfn,
>          .config_write = piix3_write_config_xen,
> +        .vendor_id    = PCI_VENDOR_ID_INTEL,
> +        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
> PCI-to-ISA bridge (Step A1)
> +        .class_id     = PCI_CLASS_BRIDGE_ISA,
>      },{
>          /* end of list */
>      }
 
shouldn't piix3_initfn take care of setting vendor_id, device_id and
class_id, as in the normal PIIX3 case?