[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/12] Adding VMDK monolithic flat support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/12] Adding VMDK monolithic flat support |
Date: |
Sat, 18 Jun 2011 19:39:58 +0100 |
On Sat, Jun 4, 2011 at 1:39 AM, Fam Zheng <address@hidden> wrote:
> This is a split patch series of the previous monolithic flat support
> version, with improvements according to Kevin's comments.
Thanks for these patches! I have left review comments for this series.
Eventually you will touch most of the vmdk code so I think using QEMU
coding style, making parsing robust, and using -errno return values
instead of just 0/-1 should be done. The existing code doesn't do
these things so it will be a little extra work but worth it in order
to make vmdk a more modern, first-class block driver in QEMU.
Stefan