Re: [Qemu-devel] [PATCH 2/9] target-ppc: Handle memory-forced I/O controller access

[Andreas Färber]

Am 18.06.2011 um 00:59 schrieb Alexander Graf:

> On 17.06.2011, at 21:34, Andreas Färber wrote:
>
> > Am 17.06.2011 um 16:43 schrieb Alexander Graf:
> >
> > > From: Hervé Poussineau <address@hidden>
> > >
> > > On at least the PowerPC 601, a direct-store (T=1) with bus unit ID  
> > > 0x07F
> > > is special-cased as memory-forced I/O controller access. It is  
> > > supposed
> > > to be checked immediately if T=1, bypassing all protection  
> > > mechanisms
> > > and acting cache-inhibited and global.
> > >
> > > Signed-off-by: Hervé Poussineau <address@hidden>
> > >
> > > Simplified by avoiding reindentation. Added explanatory comments.
> > >
> > > Cc: Alexander Graf <address@hidden>
> > > Signed-off-by: Andreas Färber <address@hidden>
> > > Signed-off-by: Alexander Graf <address@hidden>
> >
> > Feel free to remove the Cc: after adding a corresponding Sob or  
> > similar line.
>
> Hrm - I usually just use git am -s for the sob line. If you find the  
> CC irritating, please just pass it to git send-email --cc and omit  
> it from the patch. It's more or less unuseful information anyways :)

Ah, didn't know that option. I always used git am, followed by git  
commit --amend -s, at which point one can edit the commit message.

--cc becomes unhandy in a series of ~35, when not all patches concern  
everyone and to avoid forgetting CCs.

Andreas