[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] linux-user/signal.c: Remove only-ever-set varia
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 7/8] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr |
Date: |
Thu, 16 Jun 2011 17:37:14 +0100 |
Move the access of fpu_save into the commented out skeleton code for
restoring FPU registers on SPARC sigreturn, thus silencing a gcc
4.6 "variable set but never used" warning.
(This doesn't affect the calculation of 'err' because in fact
__get_user() can never fail.)
Signed-off-by: Peter Maydell <address@hidden>
---
linux-user/signal.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 11b25be..2e34ffb 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -2080,7 +2080,6 @@ long do_sigreturn(CPUState *env)
uint32_t up_psr, pc, npc;
target_sigset_t set;
sigset_t host_set;
- abi_ulong fpu_save_addr;
int err, i;
sf_addr = env->regwptr[UREG_FP];
@@ -2120,10 +2119,11 @@ long do_sigreturn(CPUState *env)
err |= __get_user(env->regwptr[i + UREG_I0],
&sf->info.si_regs.u_regs[i+8]);
}
- err |= __get_user(fpu_save_addr, &sf->fpu_save);
-
- //if (fpu_save)
- // err |= restore_fpu_state(env, fpu_save);
+ /* FIXME: implement FPU save/restore:
+ * __get_user(fpu_save, &sf->fpu_save);
+ * if (fpu_save)
+ * err |= restore_fpu_state(env, fpu_save);
+ */
/* This is pretty much atomic, no amount locking would prevent
* the races which exist anyways.
--
1.7.1
- [Qemu-devel] [PATCH 0/8] linux-user: Fix gcc 4.6 compile warnings, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 5/8] flatload: memp was a write-only variable, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 1/8] linuxload: id_change was a write only variable, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 3/8] linux-user: syscall should use sanitized arg1, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 8/8] linux-user/signal.c: Remove unused fenab, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 4/8] flatload: end_code was only used in a debug message, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 6/8] linux-user: Bump do_syscall() up to 8 syscall arguments, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 2/8] syscall: really return ret code, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 7/8] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr,
Peter Maydell <=