Re: [Qemu-devel] [PATCH] Reset system before loadvm

[Avi Kivity]

On 06/14/2011 01:56 PM, Jan Kiszka wrote:
> >
> >  I believe it is not.  But regardless, we shouldn't add more incorrect
> >  behaviour.
>
> It depends on how the reset event is defined in QMP. As I see it, there
> is nothing stated about reset reasons or sources. So emitting
> information about the actually happening reset can't be incorrect. Just
> like emitting the information about the VM stop/start around loadvm.

I don't think so.  Theoretically we could stop the vm, save a bit of 
state, reset it, and load the state back.  Did a reset occur?  Not from 
the user's point of view.

If a reset event is interesting (personally I don't think it is, so 
much, perhaps just for logging purposes), we should restrict it to user 
visible events (so it means either the user pressed the reset button or 
the guest reset itself).

--
error compiling committee.c: too many arguments to function