[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open comma
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command |
Date: |
Mon, 6 Jun 2011 17:10:32 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Fri) 03 Jun 2011 [16:03:57], Luiz Capitulino wrote:
> +static int tray_open(const char *device, int remove, int force)
> +{
> + BlockDriverState *bs;
> +
> + bs = bdrv_removable_find(device);
> + if (!bs) {
> + return -1;
> + }
> +
> + if (bdrv_eject(bs, 1, force) < 0) {
> + /* FIXME: will report undefined error in QMP */
> + return -1;
> + }
> +
> + if (remove) {
> + bdrv_close(bs);
> + }
> +
> + return 0;
> +}
What's the reason to tie the 'remove' with tray open? Won't it be
simpler to have it separated out, perhaps a 'change' event instead of
'insert' that can accept NULL which means just remove medium?
Amit
- [Qemu-devel] [RFC 03/10] QMP: query-block: Add the 'tray-open' key, (continued)
- [Qemu-devel] [RFC 03/10] QMP: query-block: Add the 'tray-open' key, Luiz Capitulino, 2011/06/03
- [Qemu-devel] [RFC 04/10] HMP: info block: Print the 'tray-open' key, Luiz Capitulino, 2011/06/03
- [Qemu-devel] [RFC 06/10] QMP: Introduce the blockdev-tray-close command, Luiz Capitulino, 2011/06/03
- [Qemu-devel] [RFC 07/10] QMP: Introduce the blockdev-media-insert command, Luiz Capitulino, 2011/06/03
- [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command, Luiz Capitulino, 2011/06/03
- Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command,
Amit Shah <=
- Re: [Qemu-devel] [RFC 05/10] QMP: Introduce the blockdev-tray-open command, Markus Armbruster, 2011/06/06
[Qemu-devel] [RFC 08/10] QMP: Introduce the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events, Luiz Capitulino, 2011/06/03
[Qemu-devel] [RFC 09/10] QMP/HMP: eject: Use blockdev-tray-open, Luiz Capitulino, 2011/06/03
[Qemu-devel] [RFC 10/10] QMP/HMP: change: Use QMP tray commands, Luiz Capitulino, 2011/06/03