[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all he
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] Correct and standardize header guards in all header files |
Date: |
Mon, 06 Jun 2011 11:36:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Alexandre Raymond <address@hidden> writes:
> As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers,
> identifiers starting with an underscore are reserved.
>
> Therefore:
> 1) Rename all incorrect header guards
>
> While I'm at it:
> 2) Standardize header guards to "#ifndef SOMETHING_H"
Consistency is good.
> 3) Repeat the header guard identifier after the closing "#endif"
Such comments can help readers to navigate #if mazes. Not the case for
header guards. Just noise.