Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

[Anthony Liguori]

On 05/31/2011 08:35 AM, Luiz Capitulino wrote:
> On Tue, 31 May 2011 10:12:17 +0200
> > Do we break anything if we make eject really eject the medium (we have a
> > virtual tray status now) instead of just closing the image?
>
> I don't think so. I guess users/clients really have the expectation that
> the only result is to get the media ejected.
>
> Now, "-f" can be used with non-removable media. There's some risk of
> breakage here if clients are using this to "unplug" devices. But I think
> this a case where we'll have to pay the price for the breakage (if any).

Only badness can ensue from doing that today so I see no reason to 
preserve this "functionality".

Regards,

Anthony Liguori

> > most visible change is that we'll eject the host medium when using
> > pass-through. I consider this an additional bugfix.
>
> Yes.