[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env |
Date: |
Thu, 26 May 2011 22:01:48 +0300 |
On Wed, May 25, 2011 at 7:00 PM, Peter Maydell <address@hidden> wrote:
> This patchset is largely aimed at rolling back the changes from an
> earlier patchset of mine:
> http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html
> which made various Neon helper routines use the correct FP status
> flags by having them use the global env.
>
> Since we've decided we're trying to get rid of the global CPUState
> pointer (at least in C code), patches 1, 5, 6 here are basically
> reverting patches 1,2,3 of that earlier patchset. In order not
> to throw the baby out with the bathwater, patches 2, 3, 4 make
> the helper routines which need to use the FP status take a pointer
> to the fp status word. (In a few cases we can then merge them
> with the equivalent VFP helpers.)
>
> This obviously still leaves some global CPUState use in op_helper.c,
> but it's a move in the right direction.
Have you seen any measurable changes in performance? The discussion
about the performance effect of changes like this was not very
conclusive.
- [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env, Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 2/6] target-arm: Add helper function to generate code to get fpstatus pointer, Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 6/6] Revert "Makefile.target: Allow target helpers to be in any *_helper.c file", Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 4/6] target-arm: Pass fp status pointer explicitly to neon fp helpers, Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 1/6] Revert "target-arm: Use global env in iwmmxt_helper.c helpers", Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 3/6] target-arm: Make VFP binop helpers take pointer to fpstatus, not CPUState, Peter Maydell, 2011/05/25
- [Qemu-devel] [PATCH 5/6] Revert "target-arm: Use global env in neon_helper.c helpers", Peter Maydell, 2011/05/25
- Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env, Peter Maydell, 2011/05/26