Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

[Markus Armbruster]

Jan Kiszka <address@hidden> writes:

> Drop the open-coded MAC assignment from net_init_nic and replace it with
> standard qemu_macaddr_default_if_unset which is also used by qdev. That
> avoid creating colliding MACs when instantiating NICs via different
> mechanisms.

Should we explicitly mention that this may change default MAC addresses?

> This change requires to store the MAC as MACAddr in NICInfo, and the
> remaining nd_table users need to be updated.
>
> Based on suggestion by Peter Maydell.

Patch looks fine to me.