Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition

[Stefan Hajnoczi]

On Wed, May 18, 2011 at 11:49:26PM +0200, Arun Thomas wrote:
> On Sun, May 1, 2011 at 6:35 PM, Stefan Hajnoczi <address@hidden> wrote:
> > On Thu, Apr 28, 2011 at 3:11 PM, Arun Thomas <address@hidden> wrote:
> >> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, 
> >> which
> >> maps to the second primary partition. To specify the first primary 
> >> partition,
> >> 'part1' should be set to 0x00, since partition numbers start from zero
> >> according to the multiboot spec.
> >>
> >> Signed-off-by: Arun Thomas <address@hidden>
> >
> > Which OSes have you tested?  Xen?  Solaris?
> 
> I tested Solaris (OpenIndiana Build 148), and it boots fine. I haven't
> been able to try Xen. Linux also boots fine, as expected.

Okay, if Solaris boots that's a good sign.  According to the spec your
change is correct, I think this patch should be applied.

Reviewed-by: Stefan Hajnoczi <address@hidden>