[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-lm32: Remove unused local variables
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH] target-lm32: Remove unused local variables |
Date: |
Mon, 9 May 2011 19:53:59 +0200 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Am Samstag 07 Mai 2011, 22:49:33 schrieb Stefan Weil:
> cppcheck report:
> target-lm32/translate.c:587: style:
> Variable 't0' is assigned a value that is never used
> target-lm32/translate.c:588: style:
> Variable 'l1' is assigned a value that is never used
>
> Remove both variables. Please check whether that is the correct solution.
>
> Cc: Michael Walle <address@hidden>
> Cc: Edgar E. Iglesias <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
Leftovers from ecbe1de823 therefore:
Acked-by: Michael Walle <address@hidden>
> ---
> target-lm32/translate.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index bcd52fe..eb21158 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -584,9 +584,6 @@ static void dec_orhi(DisasContext *dc)
>
> static void dec_scall(DisasContext *dc)
> {
> - TCGv t0;
> - int l1;
> -
> if (dc->imm5 == 7) {
> LOG_DIS("scall\n");
> } else if (dc->imm5 == 2) {
> @@ -595,9 +592,6 @@ static void dec_scall(DisasContext *dc)
> cpu_abort(dc->env, "invalid opcode\n");
> }
>
> - t0 = tcg_temp_new();
> - l1 = gen_new_label();
> -
> if (dc->imm5 == 7) {
> tcg_gen_movi_tl(cpu_pc, dc->pc);
> t_gen_raise_exception(dc, EXCP_SYSTEMCALL);