[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] target-arm: Refactor int-float conversions
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] target-arm: Refactor int-float conversions |
Date: |
Fri, 6 May 2011 15:42:23 +0100 |
On 6 May 2011 15:09, Paul Brook <address@hidden> wrote:
>> The Neon versions of int-float conversions need their own helper routines
>> because they must use the "standard FPSCR" rather than the default one.
>> Refactor the helper functions to make it easy to add the neon versions.
>> While we're touching the code, move the helpers to op_helper.c so that
>> we can use the global env variable rather than passing it as a parameter.
>
> IMO this is going in the wrong direction. We should in aiming for less
> implicit accesses to cpu state, not more.
I don't have a very strong feeling about this personally, I've just been
going in the direction suggested by past discussions eg
http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00183.html
> Maybe better would be to explicitly pass a pointer the fp status. That way you
> don't even need separate VFP and NEON variants of these routines.
If you were otherwise going to pass in a CPUState pointer then just passing
the pointer to the fp_status is probably better, yes.
-- PMM
- [Qemu-devel] [PATCH 0/7] target-arm: Fix bugs in fp exception flag setting, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 3/7] target-arm: Signal InvalidOp for Neon GE and GT compares of QNaN, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 7/7] target-arm: Signal Underflow when denormal flushed to zero on output, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 2/7] target-arm: Signal InputDenormal for VRECPE, VRSQRTE, VRECPS, VRSQRTS, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 1/7] target-arm: Don't set FP exceptions in recip, recip_sqrt estimate fns, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 6/7] softfloat: Add new flag for when denormal result is flushed to zero, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 5/7] target-arm: Add separate Neon float-int conversion helpers, Peter Maydell, 2011/05/06
- [Qemu-devel] [PATCH 4/7] target-arm: Refactor int-float conversions, Peter Maydell, 2011/05/06
Re: [Qemu-devel] [PATCH 0/7] target-arm: Fix bugs in fp exception flag setting, Peter Maydell, 2011/05/17