[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print()
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print() |
Date: |
Fri, 06 May 2011 13:11:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 05/06/11 12:40, Brad Hards wrote:
> On Fri, 6 May 2011 07:39:10 PM address@hidden wrote:
>> +/*
>> + * Add delta to current state, and print the output if the current
>> + * state has progressed more than min_skip since the last value was
>> + * printed. 'max' specifies the relative percentage, ie. a function
>> + * can count for 30% of the total work, and still count from 0-100, by
>> + * setting max to 30. If max is set to zero, the percent argument
>> + * becomes an absolute value for current state.
>> + */
>> void qemu_progress_print(float percent, int max)
> I hate to critique anyone adding docs, but this makes no sense at all to me
> without reading the code. Is "percent" the amount we are adding (i.e. the
> delta) or the result (i.e. absolute progress)? Or does it vary according to
> the value of max?
What you add is a delta, which is relative to the max. We can change the
argument name of the function to be delta instead if that makes it
easier to follow.
Cheers,
Jes
[Qemu-devel] [PATCH 2/2] qemu-img.c: Remove superfluous parenthesis, Jes . Sorensen, 2011/05/06
Re: [Qemu-devel] [PATCH qemu-block 0/2] cleanup progress code, Markus Armbruster, 2011/05/06