[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Supporting emulation of IOMMUs
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] Supporting emulation of IOMMUs |
Date: |
Thu, 28 Apr 2011 14:57:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 04/21/2011 02:39 AM, Alexander Graf wrote:
> How exactly is this going to be used? Also, in the end I think that
> most devices should just go through a PCI specific interface that
> then calls the DMA helpers:
>
> pci_memory_rw(PCIDevice *d, ...)
>
> even if it's only as simple as calling
>
> dma_memory_rw(d->iommu, ...)
I've had a read through the patches posted in January. It all does
seem relatively sane. At least, I can readily see how I would apply
these interfaces to my Alpha port without trouble.
I'll agree with Alex though that the raw dma_memory_rw functions
should not be exposed to the drivers for any given bus. They should
always go through {pci,isa}_memory_rw. And these should almost
certainly be inline functions that just pass on &device->bus.mmu.
r~