[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include state
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements) |
Date: |
Thu, 28 Apr 2011 22:04:08 +0300 |
On Thu, Apr 28, 2011 at 8:46 PM, Anthony Liguori <address@hidden> wrote:
> On 04/28/2011 12:44 PM, Stefan Weil wrote:
>>
>> Am 28.04.2011 19:39, schrieb Anthony Liguori:
>>>
>>> On 04/28/2011 12:08 PM, Stefan Weil wrote:
>>>>
>>>> From: Stefan Weil<address@hidden>
>>>>
>>>> Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
>>>> without fixing the include paths.
>>>>
>>>> Signed-off-by: Stefan Weil<address@hidden>
>>>
>>>
>>> This is not correct. I think we learned in IRC that the problem is
>>> Stefan is using CFLAGS=-g which overrides the CFLAGS append added by
>>> this patch.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>>
>> QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
>> because now users can no longer set their own CFLAGS.
>
> Use ./configure --extra-cflags="-g"
No, we should be able to override CFLAGS, because Juan made great
effort earlier to fix the logic and separate QEMU_CFLAGS and CFLAGS.
Please see a558ee17761c3c9ef22792bd5097880ab92f1bf5.
- [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements), Stefan Weil, 2011/04/28
- Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements), Anthony Liguori, 2011/04/28
- Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements), Stefan Weil, 2011/04/28
- Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements), Anthony Liguori, 2011/04/28
- Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements),
Blue Swirl <=
- [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw, Stefan Weil, 2011/04/28
- Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw, Anthony Liguori, 2011/04/28
- Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw, Stefan Weil, 2011/04/28
- Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw, Peter Maydell, 2011/04/28
[Qemu-devel] [PATCH v2] virtio-9p: Use relative includes for files in hw, Stefan Weil, 2011/04/28