[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_e
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet() |
Date: |
Wed, 13 Apr 2011 20:11:29 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Apr 12, 2011 at 11:41:49PM +0100, Peter Maydell wrote:
> On 12 April 2011 22:59, Aurelien Jarno <address@hidden> wrote:
> > I haven't look at the documentation, but for the neighbouring code it looks
> > clear that floatx80_eq() should be used instead of floatx80_eq_quiet().
>
> Actually I think it's irrelevant -- PerformComparisonOperation()
> is called only once, and the code before it carefully checks for
> any NaNs and takes a different code path in that case (jumping
> to the 'unordered' label). So it doesn't matter which function
> we use here. I don't particularly object if you think using the
> non _quiet one is aesthetically tidier. (The nwfpe code is all
> hovering on the edge of total obsolescence anyhow; I certainly
> don't have any test cases for it.)
>
Ok, I will simply drop it then.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 00/19] softfloat and FPU fixes/improvements, Aurelien Jarno, 2011/04/12
- [Qemu-devel] [PATCH 05/19] target-i386: add floatx_{add, mul, sub} and use them, Aurelien Jarno, 2011/04/12
- [Qemu-devel] [PATCH 07/19] softfloat-native: add float*_unordered_quiet() functions, Aurelien Jarno, 2011/04/12
- [Qemu-devel] [PATCH 06/19] softfloat: add float*_unordered_{, quiet}() functions, Aurelien Jarno, 2011/04/12
- [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet(), Aurelien Jarno, 2011/04/12
- [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, Aurelien Jarno, 2011/04/12
- Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, Peter Maydell, 2011/04/14
- Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, Richard Henderson, 2011/04/14
- Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, Peter Maydell, 2011/04/14
- Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, Richard Henderson, 2011/04/14