Re: [Qemu-devel] MIPS64 user mode emulation Patch

[Aurelien Jarno]

On Sat, Mar 26, 2011 at 11:58:37AM +0500, Khansa Butt wrote:
> From cd88be1263d0fc9802cd4dd358ed0299c0d106b0 Mon Sep 17 00:00:00 2001
> From: Khansa Butt & Ehsan-ul-Haq <address@hidden>
> Date: Sat, 26 Mar 2011 11:53:11 +0500
> Subject: [PATCH] MIPS64 user mode emulation in QEMU
>  This patch adds support for Cavium Network's
>  Octeon 57XX user mode instructions.  Octeon
>  57xx is based on MIPS64.  So this patch is
>  the first MIPS64 User Mode Emulation in QEMU
>  This is the team(Khansa Butt, Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed)
>  work of HPCNL Lab at KICS-UET Lahore.
> 
> 
> Signed-off-by: Khansa Butt <address@hidden>
> ---
>  configure                             |    1 +
>  default-configs/mips64-linux-user.mak |    1 +
>  exec.c                                |    1 +
>  linux-user/elfload.c                  |   15 +-
>  linux-user/main.c                     |   20 +-
>  linux-user/mips64/syscall.h           |    2 +
>  linux-user/signal.c                   |    3 +-
>  linux-user/syscall.c                  |    2 +
>  target-mips/cpu.h                     |   16 +
>  target-mips/translate.c               |  659
> ++++++++++++++++++++++++++++++++-
>  10 files changed, 704 insertions(+), 16 deletions(-)
>  create mode 100644 default-configs/mips64-linux-user.mak

Your patch actually contains 2 things
- Support for Cavium Octeon instructions
- Support for MIPS64 userland

The 2 things are independent and should be submitted as two different
patches.

Also the support for Octeon instruction should not depend on a global
variable, but should use the CPU features system already available.
Please have a look at target-mips/translate_init.c to see how it works.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net