[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status |
Date: |
Sun, 3 Apr 2011 16:32:51 +0100 |
On 3 April 2011 16:12, Aurelien Jarno <address@hidden> wrote:
> On Sun, Apr 03, 2011 at 12:21:49PM +0100, Peter Maydell wrote:
>> Anyway, how about I do a version of this patch which moves
>> the affected neon helpers to op_helper.c rather than adding
>> an env parameter
>> Then I can do a separate patchset to move other helpers,
>> rather than tangling a code-cleanup patchset with Neon
>> correctness fixes.
> This solution looks fine for me. That said, I am not sure moving
> everything to op_helper.c is the best solution. I would rather go for
> compiling *_helper.c with HELPER_CFLAGS, which avoids having one big
> file which is messy to edit, and long to compile.
That sounds better, actually, and avoids moving too much
code around. Still leaves the choice of:
* move VFP helpers from target-arm/helper.c to another file
* compile all target-*/helper.c with HELPER_CFLAGS
* arm-specific exception in Makefile.target
of which I'll go for option 1.
-- PMM
- [Qemu-devel] [PATCH 04/10] target-arm: Fix VCLE.F32 #0, VCLT.F32 #0 NaN handling, (continued)
- [Qemu-devel] [PATCH 04/10] target-arm: Fix VCLE.F32 #0, VCLT.F32 #0 NaN handling, Peter Maydell, 2011/04/01
- [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Blue Swirl, 2011/04/01
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Blue Swirl, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Peter Maydell, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Blue Swirl, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Peter Maydell, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Blue Swirl, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Aurelien Jarno, 2011/04/03
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines use correct FP status, Aurelien Jarno, 2011/04/03
[Qemu-devel] [PATCH 05/10] target-arm: Correct ABD's handling of negative zeroes, Peter Maydell, 2011/04/01
[Qemu-devel] [PATCH 03/10] target-arm: Return right result for Neon comparison with NaNs, Peter Maydell, 2011/04/01
[Qemu-devel] [PATCH 08/10] target-arm: Fix VLD of single element to all lanes, Peter Maydell, 2011/04/01
Re: [Qemu-devel] [PATCH 00/10] [PULL] ARM Neon fixes, Aurelien Jarno, 2011/04/03