[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues |
Date: |
Sun, 3 Apr 2011 14:40:15 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 01, 2011 at 07:52:52PM +0200, Stefan Weil wrote:
> [snip]
>
> Thank you for your review, especially for the hints at lduw_phys
> and potential alignment issues. I'll apply them to a new version
> of this patch.
>
> There was already a function without prefix (stl_le_phys),
> and the new ones belong to the same "family". There is nothing
> e100 specific in them, so they might be added to qemu-common.h
> as well. That was (and is) the reason why I did not add a prefix.
Yes but they don't seem to do much useful,
IMO open-coding will be clearer, they are unlikely
to be generally useful. But if you like to
keep them pls add a eepro100 prefix.
--
MST