[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail |
Date: |
Sat, 2 Apr 2011 14:48:14 +0100 |
On Fri, Apr 1, 2011 at 6:25 PM, Michael Roth <address@hidden> wrote:
> On 04/01/2011 12:01 PM, Stefan Hajnoczi wrote:
>>
>> On Fri, Apr 01, 2011 at 11:55:39AM -0500, Michael Roth wrote:
>>>
>>> I'd prefer to only document "strict" guidelines, and treat
>>> checkpatch.pl warnings ("suggestions") as an extra "reward" you get
>>> for taking the time to run it.
>>
>> I don't want to be punished for running checkpatch.pl like I'm supposed
>> to while those who don't can get away with more.
>
> You're not! These are extra morsels of goodness :)
>
>>
>> A --pedantic mode would be fine although probably no one besides the
>> author would use it :).
>
> True :) But you're right, this is probably the better approach. How bout:
>
> --warnings: print coding style warnings in addition to errors, and exit
> failure if encountered
>
> Then default to suppressing warning statements, and --no-fail-on-warn
> behavior.
Sounds good to me :).
Stefan
- Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error, (continued)
- [Qemu-devel] [PATCH 1/2] checkpatch.pl: add --no-fail-on-warn option, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Stefan Hajnoczi, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Stefan Hajnoczi, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail,
Stefan Hajnoczi <=