Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

[Stefan Weil]

Am 28.03.2011 11:24, schrieb Isaku Yamahata:
> On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote:
> > Isaku Yamahata <address@hidden> writes:
> >
> > > On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote:
> > > > Am 28.03.2011 04:17, schrieb Isaku Yamahata:
> > [...]
> > > > > On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote:
> > > > > > cirrus_reset is also called by the pci framework,
> > > > > > so there is no need to call it in cirrus_init_common.
> > > > > >
> > > > > > Cc: Michael S. Tsirkin<address@hidden>
> > > > > > Signed-off-by: Stefan Weil<address@hidden>
> > [...]
> > > > I tested the new code with isa pc, too. In gdb, I could see that it 
> > > > also
> > > > calls
> > > > cirrus_reset twice. But isa pc is broken since the switch to sea 
> > > > bios, so
> > > > obviously isa is an unmaintained part of qemu. Even with bochs bios,
> > > > it no longer works, so it is broken at least twice.
> > >
> > > Ah, I see. The the second reset is called not via pci reset framework,
> > > but qemu reset framework. So removing the above reset call makes sense.
> > > It would be another patch to make use of pci reset framework.
> >
> > Then the proposed commit message's claim cirrus_reset() is "called by
> > the pci framework" is incorrect, isn't it?
>
> Yes, incorrect. The commit message should be fixed.
> The code change itself looks correct.

For current qemu it is correct, or is there a working configuration
with isa cirrus? I asked that question on #qemu but did not get
an answer (Anthony replied that isa was broken long ago).

This was the reason why I wrote the commit text as it is.
I don't mind if the committer adds more descriptive text,
but the main focus should be fixing isa emulation.
I also noticed that some more emulations obviously also
include redundant reset calls. These should be fixed, too.