[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless |
Date: |
Thu, 24 Feb 2011 15:52:00 +0000 |
On 4 February 2011 08:05, Corentin Chary <address@hidden> wrote:
> Use the new update frequency infrastructure to use jpeg for regions with
> high update frequency.
>
> Signed-off-by: Corentin Chary <address@hidden>
> @@ -1514,6 +1536,8 @@ static int send_sub_rect(VncState *vs, int x, int y,
> int w, int h)
> uint32_t bg = 0, fg = 0;
> int colors;
> int ret = 0;
> + bool force_jpeg = false;
> + bool allow_jpeg = true;
>
> vnc_framebuffer_update(vs, x, y, w, h, vs->tight.type);
This (ie git master, since this has been committed) doesn't compile
if CONFIG_VNC_JPEG isn't defined:
cam-vm-266:maverick:qemu$ make
CC ui/vnc-enc-tight.o
cc1: warnings being treated as errors
ui/vnc-enc-tight.c: In function ‘send_sub_rect’:
ui/vnc-enc-tight.c:1540: error: unused variable ‘allow_jpeg’
ui/vnc-enc-tight.c:1539: error: unused variable ‘force_jpeg’
ui/vnc-enc-tight.c: In function ‘tight_send_framebuffer_update’:
ui/vnc-enc-tight.c:1717: error: ‘tight_jpeg_conf’ undeclared (first
use in this function)
ui/vnc-enc-tight.c:1717: error: (Each undeclared identifier is
reported only once
ui/vnc-enc-tight.c:1717: error: for each function it appears in.)
make: *** [ui/vnc-enc-tight.o] Error 1
-- PMM
- [Qemu-devel] [PATCH v3 00/16] vnc: adapative tight, zrle, zywrle, and bitmap module, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 02/16] vnc: don't set the quality if lossy encoding are disabled, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 03/16] vnc: add a way to get the update frequency for a given region, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 04/16] vnc: refresh lossy rect after a given timeout, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless, Corentin Chary, 2011/02/04
- Re: [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 06/16] vnc: palette: use a pool to reduce memory allocations, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 07/16] vnc: palette: add palette_init calls, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 08/16] vnc: palette: and fill and color calls., Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 10/16] vnc: fix uint8_t comparisons with negative values, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 09/16] vnc: Add ZRLE and ZYWRLE encodings., Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 11/16] vnc: fix lossy rect refreshing, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 12/16] bitmap: add a generic bitmap and bitops library, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 13/16] vnc: use the new generic bitmap functions, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 14/16] vnc: don't try to send bigger updates that client height, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 15/16] vnc: tight: tweak adaptive tight settings, Corentin Chary, 2011/02/04