[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/22] migration: another case of global variabl
From: |
Yoshiaki Tamura |
Subject: |
Re: [Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one |
Date: |
Wed, 23 Feb 2011 17:54:53 +0900 |
2011/2/23 Juan Quintela <address@hidden>:
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index accc6e4..4014330 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -136,9 +136,8 @@ void do_info_migrate(Monitor *mon, QObject **ret_data)
> QDict *qdict;
>
> if (current_migration) {
> - MigrationState *s = current_migration;
>
> - switch (s->state) {
> + switch (current_migration->state) {
> case MIG_STATE_NONE:
> /* no migration has happened ever */
> break;
Looks good to me.
Yoshi
> --
> 1.7.4
>
>
>
- [Qemu-devel] [PATCH 13/22] migration: Our release callback was just free, (continued)
- [Qemu-devel] [PATCH 13/22] migration: Our release callback was just free, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 15/22] migration: Remove migration cancel() callback, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 14/22] migration: Remove get_status() accessor, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 16/22] migration: Move exported functions to the end of the file, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 17/22] migration: use global variable directly, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one, Juan Quintela, 2011/02/22
- Re: [Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one,
Yoshiaki Tamura <=
- [Qemu-devel] [PATCH 19/22] migration: convert current_migration from pointer to struct, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 21/22] migration: Export a function that tells if the migration has finished correctly, Juan Quintela, 2011/02/22
- [Qemu-devel] [PATCH 22/22] migration: Make state definitions local, Juan Quintela, 2011/02/22