Re: [Qemu-devel] [PATCH 08/22] migration: Check that migration is active before cancel it

[Yoshiaki Tamura]

2011/2/23 Juan Quintela <address@hidden>:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  migration.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 397a0b9..55f58c8 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -138,7 +138,7 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, 
> QObject **ret_data)
>  {
>     MigrationState *s = current_migration;
>
> -    if (s)
> +    if (s && s->get_status(s) == MIG_STATE_ACTIVE)
>         s->cancel(s);
>
>     return 0;

Why don't you remove *s again?

Yoshi

> --
> 1.7.4
>
>
>