[Qemu-devel] Re: [PATCH v2 00/15] [uq/master] Patch queue, part IV (MCE edition)

[Marcelo Tosatti]

On Fri, Feb 18, 2011 at 11:11:11AM +0100, Jan Kiszka wrote:
> Round 2 of this part, primarily addressing review comments:
>  - Reworked CPU_INTERRUPT_MCE -> exection translation
>    (now done in kvm_arch_process_async_events, indeed much cleaner)
>  - Add missing cpu_synchronize_state on pending MCE events for
>    !kvm_irqchip_in_kernel
>  - Split up KVM MCE code switch from old to new style into two patches
>    and dropped some unneeded variable renamings
>  - Fixed Windows build (qemu_ram_remap is POSIX-only)
> 
> Thanks for the feedback so far.
> 
> CC: Hidetoshi Seto <address@hidden>
> CC: Huang Ying <address@hidden>
> CC: Jin Dongming <address@hidden>
> 
> Huang Ying (2):
>   Add qemu_ram_remap
>   KVM, MCE, unpoison memory address across reboot
> 
> Jan Kiszka (13):
>   x86: Account for MCE in cpu_has_work
>   x86: Perform implicit mcg_status reset
>   x86: Small cleanups of MCE helpers
>   x86: Refine error reporting of MCE injection services
>   x86: Optionally avoid injecting AO MCEs while others are pending
>   Synchronize VCPU states before reset
>   kvm: x86: Move MCE functions together
>   kvm: Rename kvm_arch_process_irqchip_events to async_events
>   kvm: x86: Inject pending MCE events on state writeback
>   x86: Run qemu_inject_x86_mce on target VCPU
>   kvm: x86: Consolidate TCG and KVM MCE injection code
>   kvm: x86: Clean up kvm_setup_mce
>   kvm: x86: Fail kvm_arch_init_vcpu if MCE initialization fails
> 
>  cpu-all.h             |    8 +-
>  cpu-common.h          |    1 +
>  exec.c                |   63 +++++++-
>  kvm-all.c             |    2 +-
>  kvm.h                 |    2 +-
>  monitor.c             |   11 +-
>  qemu-common.h         |    6 +-
>  target-i386/cpu.h     |   11 +-
>  target-i386/exec.h    |   15 +-
>  target-i386/helper.c  |  185 +++++++++++++-------
>  target-i386/kvm.c     |  463 
> ++++++++++++++++++++-----------------------------
>  target-i386/kvm_x86.h |   25 ---
>  target-ppc/kvm.c      |    2 +-
>  target-s390x/kvm.c    |    2 +-
>  vl.c                  |    1 +
>  15 files changed, 399 insertions(+), 398 deletions(-)
>  delete mode 100644 target-i386/kvm_x86.h
> 

Looks good.