Re: [Qemu-devel] [PATCH 2/4] softfloat: add float32_set_sign(), float32_infinity, float64_half, float64_256 and float64_512.

[Christophe Lyon]

On 20.02.2011 23:20, Aurelien Jarno wrote:
> On Sun, Feb 20, 2011 at 10:09:46PM +0000, Peter Maydell wrote:
>> On 20 February 2011 21:52, Aurelien Jarno <address@hidden> wrote:
>>> While it's probably a good idea to define the commonly used values in
>>> softfloat.h, I don't think we should have all the values used by the
>>> different targets here. Infinity, one, half, two probably have their
>>> place here, I don't think it's the case of 256 and 512. It should be
>>> better to defined them at the target level.
>>
>> Are you happy with targets just doing make_float*() on a
>> bit pattern? I guess that's the most straightforward thing,
> 
> Yes, I think it is the way to go.
> 
OK I will change that.


>>> Also for consistency, I
>>> think it's better to define these value for all float size, or at least
>>> for all the common ones (32, 64, maybe 16).
>>
>> I wouldn't bother with 16, only ARM uses that and only for
>> conversions to other formats.
>>
> 
> That's true, so let's do it float 32 and 64.
> 
I will add these too.

Christophe.