[Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support

[Kevin Wolf]

Am 15.02.2011 17:27, schrieb Michael S. Tsirkin:
> e1000 supports multi-buffer packets larger than rxbuf_size.
> 
> This fixes the following (on linux):
> - in guest: ifconfig eth1 mtu 16110
> - in host: ifconfig tap0 mtu 16110
>            ping -s 16082 <guest-ip>
> 
> Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205
> 
> Changes from v1:
>       fix buffer overflow reported by Kevin
>       added a patch to fix EOP spec violation reported by Juan
>       added a patch to fix spec violation noted by myself
> 
> 
> Michael S. Tsirkin (3):
>   e1000: multi-buffer packet support
>   e1000: clear EOP for multi-buffer descriptors
>   e1000: verify we have buffers, upfront
> 
>  hw/e1000.c |   61 +++++++++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 48 insertions(+), 13 deletions(-)

I found patch 3 to be not that easy to understand (especially the
s->check_rxov part), but after thinking a while about it, it seems to
make sense.

Acked-by: Kevin Wolf <address@hidden>