qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode


From: Stefan Weil
Subject: [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode
Date: Wed, 16 Feb 2011 20:48:00 +0100

Reverse mode is unusable:

        qemu -vnc localhost:5500,reverse

crashes in vnc_refresh_server_surface because some pointers are NULL.

Fix this by calling vnc_dpy_resize (which initializes these pointers)
before calling vnc_refresh.

Cc: Anthony Liguori <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
 ui/vnc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index da83adf..096b5f3 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
     vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
     if (vd->timer == NULL && !QTAILQ_EMPTY(&vd->clients)) {
         vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
+        vnc_dpy_resize(vd->ds);
         vnc_refresh(vd);
     }
 }
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]